feat: add score property, withCount, and matchesText options #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 83.78% 83.95% +0.17%
==========================================
Files 105 105
Lines 11154 11256 +102
==========================================
+ Hits 9345 9450 +105
+ Misses 1809 1806 -3
Continue to review full report at Codecov.
|
Conflicts: ParseSwift.playground/Pages/2 - Finding Objects.xcplaygroundpage/Contents.swift
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
matchesTextquery constraint along with ability to seescore. Completes missing server features from Full Text Search Support parse-server#3904withCountquery constraint is missing, discussed in Add count flag to Parse.Query.find Parse-SDK-JS#865Related issue: #n/a
Approach
Add the capabilities mentioned above similar to the JS SDK implementations. Examples of how the new features can be used are in the modified Swift Playground files.
A breaking change is introduced because
scoreshould be a reserved property that can' be modified by developers. The compiler with assist developers in addressing the change by recommendingvar score: Double?be added to allParseObject's.Changes you will need to make:
var score: Double?to allParseObject'sTODOs before merging